Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CW-898 fix fast scanner #1957

Merged
merged 10 commits into from
Jan 30, 2025
Merged

CW-898 fix fast scanner #1957

merged 10 commits into from
Jan 30, 2025

Conversation

MrCyjaneK
Copy link
Collaborator

Description

Updates:

  • Boofcv bump 0.44 -> 1.17
  • Zxing implemented
  • Scan using both because none of them works for all cases.. eh.

This will reduce performance of UR scanning significantly, please do not merge for now, we need extensive testing on this one

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods

@MrCyjaneK MrCyjaneK marked this pull request as draft January 14, 2025 12:00
@MrCyjaneK MrCyjaneK marked this pull request as ready for review January 21, 2025 10:44
@OmarHatem28 OmarHatem28 merged commit 448b480 into main Jan 30, 2025
3 checks passed
@OmarHatem28 OmarHatem28 deleted the CW-898-fix-fast-scanner branch January 30, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarHatem28 OmarHatem28 OmarHatem28 approved these changes

Assignees
No one assigned
Labels
Waiting Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrCyjaneK @OmarHatem28